Skip to content

[AI Improvement] [Task] Delete orphaned mockDiscoveryServer in functions runtime discovery - #11108

Draft
joehan wants to merge 1 commit into
mainfrom
ai-improve-563464527-task-delete-orphaned-mockdiscoverys
Draft

joehan wants to merge 1 commit into
mainfrom
ai-improve-563464527-task-delete-orphaned-mockdiscoverys

Conversation

@joehan

@joehan joehan commented Sep 18, 2026

Copy link
Copy Markdown
Member

Resolves Buganizer b/563464527

Proposed Improvement

Deletes the orphaned and unused src/deploy/functions/runtimes/discovery/mockDiscoveryServer.ts.

  • mockDiscoveryServer.ts was originally added in commit 0b0459bfde as an in-process Express mock server for discovery endpoints.
  • In commit bd67ccbcdd, tests were refactored to use nock for HTTP interception, removing all references and imports to mockDiscoveryServer.ts.
  • Repository-wide audit confirmed zero imports or references across src/, scripts/, and tests.
  • Removing this dead file cleans up unused legacy code and reduces codebase clutter.

Verification

  • Ran discovery unit tests: mocha 'src/deploy/functions/runtimes/discovery/*.spec.ts' — all 157 tests passed cleanly.
  • Ran full TypeScript compilation and asset build: npm run build — built successfully with zero errors.

@joehan joehan self-assigned this Sep 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an Express.js server implementation that served a backend YAML configuration file on port 8080 (or a port specified by the ADMIN_PORT environment variable). I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants