BUG: functions:secrets:prune was not affecting secrets created after apphosting launch#10840
Open
Berlioz wants to merge 2 commits into
Open
BUG: functions:secrets:prune was not affecting secrets created after apphosting launch#10840Berlioz wants to merge 2 commits into
Berlioz wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pruneSecrets function in src/functions/secrets.ts to retrieve secrets labeled with either true or functions when collecting Firebase-managed secrets. There are no review comments, and I have no feedback to provide.
shettyvarun268
approved these changes
Jul 22, 2026
shettyvarun268
left a comment
shettyvarun268
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see:
firebase-tools/src/gcp/secretManager.ts
Line 474 in 16fb909