[DO NOT MERGE] feat: support schedule, task queue, and blocking triggers for run platform#10838
Open
inlined wants to merge 2 commits into
Open
[DO NOT MERGE] feat: support schedule, task queue, and blocking triggers for run platform#10838inlined wants to merge 2 commits into
inlined wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables schedule, task queue, and blocking triggers for Cloud Run functions, and introduces validation to prevent enrolling or unenrolling in declarative security during partially filtered deployments. It also updates the default service account representation from 'default' to null. Feedback on the changes identifies a bug in the deployment planner where the isFiltered check is not restricted to the current codebase, which can incorrectly mark other codebases as filtered during multi-codebase deployments. A code suggestion is provided to resolve this issue.
inlined
changed the title
…tform ### Description This change adds trigger parity for 'run' platform functions (Cloud Run functions) so they support scheduled, task queue, and blocking triggers when deploying via firebase-tools. Previously, these triggers would throw a "not supported yet" error. ### Scenarios Tested - Ran mocha unit tests for the fabricator file (`npx mocha lib/deploy/functions/release/fabricator.spec.js`) and verified all tests passed successfully, including new tests verifying scheduled, task queue, and blocking triggers deploy and delete properly. - Compiled the `junkdrawer` functions test code using the forced "run" platform and verified it builds. ### Sample Commands - `firebase deploy --only functions`
inlined
force-pushed
the
run-platform-triggers
branch
from
July 22, 2026 22:49
203c1fc to
87193e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds trigger parity for 'run' platform functions (Cloud Run functions) so they support scheduled, task queue, and blocking triggers when deploying via firebase-tools. Previously, these triggers would throw a "not supported yet" error.
Scenarios Tested
npx mocha lib/deploy/functions/release/fabricator.spec.js) and verified all tests passed successfully, including new tests verifying scheduled, task queue, and blocking triggers deploy and delete properly.junkdrawerfunctions test code using the forced "run" platform and verified it builds.Sample Commands
firebase deploy --only functions