Skip to content

fix: surface clear error when venv's python version doesn't match con…#10837

Draft
IzaakGough wants to merge 4 commits into
mainfrom
@invertase/fix-issue-6626
Draft

fix: surface clear error when venv's python version doesn't match con…#10837
IzaakGough wants to merge 4 commits into
mainfrom
@invertase/fix-issue-6626

Conversation

@IzaakGough

@IzaakGough IzaakGough commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #6626

@wiz-9635d3485b

wiz-9635d3485b Bot commented Jul 22, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 2 Medium 1 Low
Software Management Finding Software Management Findings -
Total 2 Medium 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Python version mismatch check that compares the configured runtime version with the actual version in the virtual environment's pyvenv.cfg file, throwing a clear error if they do not match. It also adds comprehensive unit tests for this new functionality. The review feedback suggests removing the Windows-specific exclusion check, as the pyvenv.cfg parsing is cross-platform and would benefit Windows users as well, which also allows for simplifying the associated unit tests by removing the platform stubbing.

Comment thread src/deploy/functions/runtimes/python/index.ts Outdated
Comment thread src/deploy/functions/runtimes/python/index.spec.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firebase Functions for Python tries to deploy python311 even though I'm using python310

2 participants