Skip to content

fix: add validation for names of task queue funcs#10834

Open
IzaakGough wants to merge 3 commits into
mainfrom
@invertase/fix-issue-7365
Open

fix: add validation for names of task queue funcs#10834
IzaakGough wants to merge 3 commits into
mainfrom
@invertase/fix-issue-7365

Conversation

@IzaakGough

@IzaakGough IzaakGough commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #7365

This PR adds validation for task queue function names, ensuring that, in particular, they don't include underscores.

Testing

  • Manually verified that attempting to deploy a task queue function with a name containing an underscore is met with an informative error.
  • Automated tests pass

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces validation for task queue function names at deploy time to ensure they conform to Cloud Tasks queue ID naming rules, which prohibit underscores and limit names to 100 characters. It adds the taskQueueFunctionNamesAreValid validation function, integrates it into the deployment pipeline, and includes corresponding unit tests and a changelog entry. There are no review comments, and I have no additional feedback to provide.

@IzaakGough
IzaakGough marked this pull request as ready for review July 21, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firebase deploy fails to delete task function with an underscore in its name

2 participants