fix(apptesting): display clear quota exhaustion message on 429 error#10824
Draft
lfkellogg wants to merge 2 commits into
Draft
fix(apptesting): display clear quota exhaustion message on 429 error#10824lfkellogg wants to merge 2 commits into
lfkellogg wants to merge 2 commits into
Conversation
### Description Intercept 429 HTTP status codes and RESOURCE_EXHAUSTED / QUOTA_EXCEEDED errors when requesting test execution in App Testing, surfacing a human-readable quota error message. ### Scenarios Tested - Unit test for createReleaseTest handling 429 response. ### Sample Commands firebase apptesting:execute --app 1:123:android:abc TAG=agy CONV=107aa4d3-03d0-4299-afcc-27e78b24392e
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error handling in the App Distribution client by explicitly catching and reporting quota exhaustion errors (HTTP 429, RESOURCE_EXHAUSTED, QUOTA_EXCEEDED) when creating a release test. The feedback recommends removing the substring check for "429" in the error message to avoid false positives, as the HTTP status check already handles this case sufficiently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intercept 429 HTTP status codes and RESOURCE_EXHAUSTED / QUOTA_EXCEEDED errors when requesting test execution in App Testing, surfacing a human-readable quota error message.
Scenarios Tested
Sample Commands
firebase apptesting:execute --app 1:123:android:abc
TAG=agy
CONV=107aa4d3-03d0-4299-afcc-27e78b24392e