fix: improve error message when deploying to a gcp project where fire…#10820
Open
IzaakGough wants to merge 3 commits into
Open
fix: improve error message when deploying to a gcp project where fire…#10820IzaakGough wants to merge 3 commits into
IzaakGough wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the user experience by catching 404 errors when retrieving the Firebase Admin SDK configuration and throwing a friendly error message if Firebase is not enabled on the Google Cloud project. It also adds corresponding unit tests in functionsConfig.spec.ts. The review feedback correctly points out a style guide violation where any is used for the caught error in src/functionsConfig.ts, suggesting unknown instead.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
IzaakGough
marked this pull request as ready for review
July 21, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10379
This PR improves the error message produced when a user attempts to deploy to a gcp project which doesn't have firebase added/enabled.