fix: bump ws dependency from ^7.5.10 to ^8.21.1 (CVE-2026-48779)#10817
Open
rajat2911 wants to merge 3 commits into
Open
fix: bump ws dependency from ^7.5.10 to ^8.21.1 (CVE-2026-48779)#10817rajat2911 wants to merge 3 commits into
rajat2911 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ws dependency in package.json to a new major version (^8.21.1). The review feedback correctly points out that the corresponding TypeScript type definitions (@types/ws) in devDependencies should also be updated to ^8.x.x to prevent potential type mismatch or compilation errors.
rajat2911
force-pushed
the
fix/bump-ws-to-8.21.1
branch
from
July 27, 2026 01:19
f745d10 to
79f56d2
Compare
Author
|
Hello @inlined @shettyvarun268 @Berlioz Could you guys please review this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
wsdirect dependency from^7.5.10to^8.21.1and aligns@types/wsin devDependencies from^7.2.3to^8.18.1to address CVE-2026-48779 — a remote memory exhaustion DoS vulnerability.Closes #10816
Changes
ws^7.5.10^8.21.1@types/ws^7.2.3^8.18.1Vulnerability
wsserver or client due to OOM.ws@8.21.0/ws@8.21.1See: https://github.com/websockets/ws/releases/tag/8.21.0
Why
^7.5.10doesn't helpThe current
^7.5.10range is forever locked to7.x. The vulnerability fix landed in8.21.0, so a major version bump is required — semver resolution will never pull in8.xfrom a^7.xrange.Compatibility
The
ws8.x API is backward-compatible for the usage patterns in this codebase (WebSocket.Server,ws.send(),ws.on("connection", ...)). No code changes are required beyond the version bumps inpackage.json.Impact for consumers
Without this change, downstream users are forced to apply workarounds like npm
overridesor yarnresolutionsto avoid shipping vulnerable code — an unnecessary burden that an upstream fix eliminates.