Skip to content

Remove the unused "annotations" variable for Local Builds#10540

Draft
falahat wants to merge 4 commits into
local_build_remove_um_hackfrom
local_build_remove_annotations
Draft

Remove the unused "annotations" variable for Local Builds#10540
falahat wants to merge 4 commits into
local_build_remove_um_hackfrom
local_build_remove_annotations

Conversation

@falahat
Copy link
Copy Markdown
Contributor

@falahat falahat commented May 20, 2026

Description

This was read from Universal Maker's output but we weren't actually piping it anywhere.

Scenarios Tested

Sample Commands

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the annotations and metadata fields from the App Hosting local build workflow, including updates to the AppHostingBuildOutput and LocalBuild interfaces and the removal of associated logic and unit test assertions. Reviewer feedback recommends updating the JSDoc for processUniversalMakerOutput and localBuild to ensure the documentation accurately reflects the removal of these fields.

I am having trouble creating individual review comments. Click here to see my feedback.

src/apphosting/localbuilds.ts (143-146)

medium

The metadata field has been removed from the return type of processUniversalMakerOutput. The JSDoc for this function (line 114) should be updated to reflect that it no longer parses or returns metadata.

src/apphosting/localbuilds.ts (205)

medium

The annotations field has been removed from the return type of localBuild. The JSDoc for this function (lines 187-191) should be updated to remove the reference to annotations and the mention of returning metadata (line 183) to keep the documentation accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants