Integrate new FSQL AgentService API#10531
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors Data Connect schema and operation generation to utilize a new streaming API, incorporating local schema validation via the emulator and improved progress tracking. Feedback highlights several technical concerns: the use of synchronous file I/O within asynchronous functions, fragile NDJSON parsing logic that may fail on partial stream chunks, and inconsistent indentation. Additionally, there is a significant discrepancy in the environment URL configuration that conflicts with test expectations. It is also recommended to treat invalid GraphQL response validations as errors rather than information messages for better visibility.
chkuang-g
left a comment
chkuang-g
left a comment
There was a problem hiding this comment.
Update CHANGELOG.md as well :)
fredzqm
left a comment
fredzqm
left a comment
There was a problem hiding this comment.
Nice, super excited!
Can you include a screencast of the new UX? We can use some feedbacks from Marissa.
Are we planning to do a bugbash?
| parse(res); | ||
| } catch (e: any) { | ||
| logger.error(res); | ||
| vscode.window.showErrorMessage( |
There was a problem hiding this comment.
Even if they aren't valid, I think we should still insert them.
They are probably close enough that customers can build on top of and iterate.
There was a problem hiding this comment.
going to delay this to another PR. I'm planning to add a diff view before insertion as well, and your idea applies here
UX is identical (edit: accept for notification). Only under the hood changes. Definitely will be hosting bug blashes! EDIT - added a screencast to show notification changes |
4 participants
Replace generateSchema and generateQuery backends with the new fdc AgentService API.
Verification:
https://screencast.googleplex.com/cast/NTI3MTY4NjczODg3MDI3Mnw2NmEyZDEwNS1hNA
TODO:
Cleanup CloudAICompanion references and API enablement checks
Update CLI init flow to check for Markdown references properly
Consider inserting code as a diff in VSCode