-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[AI] Thinking Levels: minimal, medium, integration tests, and encoding unit tests #15647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini summarize |
|
/gemini review |
Summary of ChangesThis pull request enhances the AI model configuration by adding 'minimal' and 'medium' thinking levels, providing more granular control over the model's reasoning process. It includes new integration tests to verify these levels with the Gemini 3 Flash Preview model and updates encoding unit tests to ensure proper handling of the expanded Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces minimal and medium thinking levels for Gemini models, along with corresponding integration and unit tests. The implementation of the new levels is correct. However, I've identified a couple of areas for improvement in the tests. The integration test contains some duplicated code that can be simplified for better readability. More importantly, the new unit tests for encoding ThinkingConfig have incorrect indentation in the expected JSON strings, which would likely cause the tests to fail. I've provided suggestions to fix these issues. Overall, good work on adding the new functionality and tests.
FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Show resolved
Hide resolved
andrewheard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM but please adjust the medium doc comment.
FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
On gemini2_5_Flash, For For |
|
Merging here. Any additional followup can be addressed in #15557 |
One strange note is that adding integration tests for 2.5 succeeds for minimal and medium, but fails for low and high
#no-changelog