Skip to content

docs: clarify Firestore auth context event fields#1904

Open
SSDWGG wants to merge 2 commits into
firebase:masterfrom
SSDWGG:docs/firestore-auth-context-1706
Open

docs: clarify Firestore auth context event fields#1904
SSDWGG wants to merge 2 commits into
firebase:masterfrom
SSDWGG:docs/firestore-auth-context-1706

Conversation

@SSDWGG

@SSDWGG SSDWGG commented Jun 13, 2026

Copy link
Copy Markdown

Summary

  • clarify that Firestore *WithAuthContext triggers expose event.authType and event.authId
  • add a short JSDoc description for FirestoreAuthEvent
  • keep the change documentation-only; no runtime behavior changes

Fixes #1706

Testing

  • Not run; documentation-only change.

@google-cla

google-cla Bot commented Jun 13, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JSDoc documentation in src/v2/providers/firestore.ts to clarify the usage of the authentication context (event.authType and event.authId) in Firestore event triggers and the FirestoreAuthEvent interface. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] No detailed information on Firestore triggers *WithAuthContext()

2 participants