feat(firestore): add support for remaining string expressions#7978
feat(firestore): add support for remaining string expressions#7978
Conversation
Adds support for string expressions `ltrim`, `rtrim`, `stringRepeat` `stringReplaceOne` `stringReplaceAll`, `stringIndexOf`. Ported from: googleapis/java-firestore#2326
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several string manipulation functions to the Firestore pipeline API, including ltrim, rtrim, stringRepeat, stringReplaceAll, stringReplaceOne, and stringIndexOf. These functions are added to the Expression class, updated in the public API definition, and supported by new unit tests. The review feedback identifies a duplicate 'substring' key in the FunctionRegistry map that should be removed to avoid redundancy and potential confusion.
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/FunctionRegistry.kt
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces several new string-related pipeline expressions to Firestore, including ltrim, rtrim, stringIndexOf, stringRepeat, stringReplaceOne, and stringReplaceAll. The changes encompass API definition updates, DSL implementations in the Expression class, and comprehensive instrumentation tests for each new function. One minor issue was identified in the CHANGELOG.md where a pull request number in the link text was inconsistent with the actual URL.
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt
Outdated
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces several new string-related pipeline expressions, including ltrim, rtrim, stringIndexOf, stringRepeat, stringReplaceOne, and stringReplaceAll. It also graduates the Pipeline API from Beta status by removing the @beta annotations. Comprehensive unit tests for the new expressions have been added. The review feedback suggests a minor documentation update to ensure consistency with the renaming of the valueToTrim parameter to valuesToTrim.
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt
Show resolved
Hide resolved
2 participants
Adds support for string expressions
ltrim,rtrim,stringRepeatstringReplaceOnestringReplaceAll,stringIndexOf.Ported from: googleapis/java-firestore#2326