feat(dataconnect): add "X-Firebase-Sqlconnect-Affinity" header for GSLB soft stickiness - #3227
Open
dconeybe wants to merge 2 commits into
Open
feat(dataconnect): add "X-Firebase-Sqlconnect-Affinity" header for GSLB soft stickiness#3227dconeybe wants to merge 2 commits into
dconeybe wants to merge 2 commits into
Conversation
reduce the chance that the caller will invert the two string arguments.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the 'X-Firebase-Sqlconnect-Affinity' header to the Data Connect API client, constructed from the project ID and service ID. The review feedback recommends using a delimiter (such as ':') between the project ID and service ID to avoid potential key collisions and ambiguity, and suggests updating the corresponding unit tests to reflect this change.
dconeybe
marked this pull request as ready for review
July 31, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
X-Firebase-Sqlconnect-Affinityrequest header to outgoing Data Connect HTTP requests. This header enables backend server affinity routing for SQL Connect to improve server resource usage efficiency and performance.Highlights
X-Firebase-Sqlconnect-Affinityheader containing${projectId}${serviceId}to Data Connect HTTP request headers.EXPECTED_HEADERS,EXPECTED_HEADERS_WITH_GEN, andEMULATOR_EXPECTED_HEADERStest fixtures to verify the header key and formatted value.Changelog
GetHeadersParametersinterface and updatedgetHeadersfunction to accept parameters by name.X-Firebase-Sqlconnect-Affinityheader containing${projectId}${serviceId}to request headers.makeGqlRequestto resolveprojectIdand pass named parameters togetHeaders.X-Firebase-Sqlconnect-Affinityheader assertion toEXPECTED_HEADERS,EXPECTED_HEADERS_WITH_GEN, andEMULATOR_EXPECTED_HEADERS.