Skip to content

Fix: Update pagination token key to 'nextPageToken' in ListTenantsResponse #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddharthmohan619-eng wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix: Update pagination token key to 'nextPageToken' in ListTenantsResponse #1194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/firebase/auth/internal/ListTenantsResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public final class ListTenantsResponse {
@Key("tenants")
private List<Tenant> tenants;

@Key("pageToken")
@Key("nextPageToken")
private String pageToken;
Copy link

@gemini-code-assist gemini-code-assist bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The field name pageToken is now inconsistent with the JSON key nextPageToken specified in the @Key annotation on line 33. For better code clarity and maintainability, consider renaming this field to nextPageToken. This would likely require updating the constructor and the getPageToken() method as well. If this refactoring is out of scope for this PR, it could be addressed in a follow-up.

Copy link
Author

@siddharthmohan619-eng siddharthmohan619-eng Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hanges made according to it


@VisibleForTesting
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/google/firebase/auth/internal/ListTenantsResponseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void testDeserialization() throws Exception {
"tenants", ImmutableList.of(
ImmutableMap.of("name", "projects/project-id/resource/TENANT_1"),
ImmutableMap.of("name", "projects/project-id/resource/TENANT_2")),
"pageToken", "PAGE_TOKEN"));
"nextPageToken", "PAGE_TOKEN"));
ListTenantsResponse response = JSON_FACTORY.fromString(json, ListTenantsResponse.class);

assertEquals(2, response.getTenants().size());
Expand Down