Skip to content

fix: corrected about us #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
therobrob wants to merge 5 commits into
base: main
Choose a base branch
from
+38 −15
Open

fix: corrected about us #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
748f7ea
fix: corrected about us
therobrob Jan 18, 2026
f6c1047
fix: corrected about us
therobrob Jan 18, 2026
b0694df
fix: corrected about us
therobrob Jan 18, 2026
fdfb779
fix: aria-labels
lenderom Jan 19, 2026
6c49a14
feat: Remove hover effect
MoritzWeber0 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/sass/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ figure {
}
}

.o-single__content figure {
border-radius: var(--border-radius-m);
}

.o-list__picture {
margin-right: 1.2rem;
display: flex;
Expand Down
4 changes: 0 additions & 4 deletions assets/sass/teamMember.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@
border-radius: var(--border-radius-m);
transition: transform 0.2s ease;

&:hover {
transform: translateY(-0.2rem);
}

&__image {
width: 8rem;
height: 8rem;
Expand Down
4 changes: 2 additions & 2 deletions content/about-us/index.de.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ Um individuellen Fragen bestmöglich zu begegnen, betreiben wir zusätzlich die

{{% team-members %}}

Doch ohne unsere großartige [Community](https://discord.gg/5nWS9Eu9zz) wäre das Projekt nicht dort, wo es heute steht. Daher ein herzliches Dankeschön an alle, die uns unterstützen – sei es durch Übersetzungen, Feedback oder das Teilen wertvoller Informationen zur Nutzung von FIP!
Doch ohne unsere großartige {{< link url="https://discord.gg/5nWS9Eu9zz" text="Community" arialabel="FIP Guide Community auf Discord" >}} wäre das Projekt nicht dort, wo es heute steht. Daher ein herzliches Dankeschön an alle, die uns unterstützen – sei es durch Übersetzungen, Feedback oder das Teilen wertvoller Informationen zur Nutzung von FIP!

Besonderen Dank gilt dabei [Toni Arndt](https://www.linkedin.com/in/toni-arndt-683228174/) sowie Kolleg:innen der DB, SNCF, PKP und ČD für zahlreiche inhaltliche Unterstützungen.
Besonderen Dank gilt dabei {{< link url="https://www.linkedin.com/in/toni-arndt-683228174/" text="Toni Arndt" arialabel="Toni Arndt auf LinkedIn" >}} sowie Kolleg:innen der DB, SNCF, PKP und ČD für zahlreiche inhaltliche Unterstützungen.
4 changes: 2 additions & 2 deletions content/about-us/index.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ To address individual questions in the best possible way, we also operate the [F

{{% team-members %}}

But without our great [community](https://discord.gg/5nWS9Eu9zz), the project would not be where it is today. Therefore, a heartfelt thank you to everyone who supports us – whether through translations, feedback, or sharing valuable information about using FIP!
But without our great {{< link url="https://discord.gg/5nWS9Eu9zz" text="community" arialabel="FIP Guide Community on Discord" >}}, the project would not be where it is today. Therefore, a heartfelt thank you to everyone who supports us – whether through translations, feedback, or sharing valuable information about using FIP!

Special thanks go to [Toni Arndt](https://www.linkedin.com/in/toni-arndt-683228174/) as well as colleagues from DB, SNCF, PKP, and ČD for their numerous contributions and support.
Special thanks go to {{< link url="https://www.linkedin.com/in/toni-arndt-683228174/" text="Toni Arndt" arialabel="Toni Arndt on LinkedIn" >}} as well as colleagues from DB, SNCF, PKP, and ČD for their numerous contributions and support.
6 changes: 3 additions & 3 deletions content/about-us/index.fr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ Pour répondre au mieux aux questions individuelles, nous exploitons également

{{% /float-image %}}

## L’équipe
## L'équipe

{{% team-members %}}

Mais sans notre formidable [communauté](https://discord.gg/5nWS9Eu9zz), le projet ne serait pas là où il en est aujourd’hui. Un grand merci à toutes celles et ceux qui nous soutiennent – que ce soit par des traductions, des retours ou le partage d’informations précieuses sur l’utilisation du FIP !
Mais sans notre formidable {{< link url="https://discord.gg/5nWS9Eu9zz" text="communauté" arialabel="Communauté FIP Guide sur Discord" >}}, le projet ne serait pas là où il en est aujourd'hui. Un grand merci à toutes celles et ceux qui nous soutiennent – que ce soit par des traductions, des retours ou le partage d'informations précieuses sur l'utilisation du FIP !

Une mention spéciale à [Toni Arndt](https://www.linkedin.com/in/toni-arndt-683228174/) ainsi qu’aux collègues de la DB, SNCF, PKP et ČD pour leurs nombreux soutiens de contenu.
Une mention spéciale à {{< link url="https://www.linkedin.com/in/toni-arndt-683228174/" text="Toni Arndt" arialabel="Toni Arndt sur LinkedIn" >}} ainsi qu'aux collègues de la DB, SNCF, PKP et ČD pour leurs nombreux soutiens de contenu.
3 changes: 2 additions & 1 deletion i18n/de.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,13 @@ teamMembers:
lennart:
name: Lennart Rommeiß
position: Cloud-Specialist @ DB Systel
linkedin: LinkedIn-Profil
moritz:
name: Moritz Weber
position: Experte Digitalisierung Bahnbetrieb @ DB InfraGO
robert:
name: Robert Schuster
position: User Experience Consulting @ DB Systel
position: User Experience Consultant @ DB Systel
willy:
name: Willy Schreiter
position: 'Product Owner bei der #Einfachbahn @ DB InfraGO'
Expand Down
3 changes: 2 additions & 1 deletion i18n/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,13 @@ teamMembers:
lennart:
name: Lennart Rommeiß
position: Cloud Specialist @ DB Systel
linkedin: LinkedIn profile
moritz:
name: Moritz Weber
position: Expert for Digitalization of Railway Operations @ DB InfraGO
robert:
name: Robert Schuster
position: User Experience Consulting @ DB Systel
position: User Experience Consultant @ DB Systel
willy:
name: Willy Schreiter
position: 'Product Owner at #Einfachbahn @ DB InfraGO'
Expand Down
3 changes: 2 additions & 1 deletion i18n/fr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,13 @@ teamMembers:
lennart:
name: Lennart Rommeiß
position: Spécialiste Cloud @ DB Systel
linkedin: Profil LinkedIn
moritz:
name: Moritz Weber
position: Expert digitalisation de l'exploitation ferroviaire @ DB InfraGO
robert:
name: Robert Schuster
position: Conseil en expérience utilisateur @ DB Systel
position: consultant en expérience utilisateur @ DB Systel
willy:
name: Willy Schreiter
position: 'Product Owner chez #Einfachbahn @ DB InfraGO'
Expand Down
9 changes: 8 additions & 1 deletion layouts/partials/link.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
{{- $url := .Destination -}}
{{- $arialabel := "" -}}
{{- if reflect.IsMap . -}}
{{- $arialabel = .Arialabel | default "" -}}
{{- end -}}
{{- if and (strings.HasPrefix $url "http") (not (strings.HasPrefix $url site.BaseURL)) -}}
{{- /* Absolute links pointing to external pages, e. g. `https://example.com` */ -}}
<a
href="{{ .Destination }}"
target="_blank"
rel="noopener noreferrer external"
class="o-link__external"
{{- with .Title -}}title="{{ . }}"{{- end -}}
{{- with .Title }}title="{{ . }}"{{- end -}}
{{- with $arialabel }}
aria-label="{{ . }}"
{{- end -}}
Comment on lines +14 to +16
Copy link
Member

@MoritzWeber0 MoritzWeber0 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- with $arialabel }}
aria-label="{{ . }}"
{{- end -}}
{{- with .Title }}aria-label="{{ . }}"{{- end -}}

What do you think of reusing the title for the aria-label? This has the advantage that the aria-label can specified using the Markdown link syntax ([text](link "aria-label")) and we don't need the custom shortcode. And we use the the same content for title and aria-label, so we use the aria-label information for the hover effect too, which I think makes sense in our scope.

>
{{- .Text -}}{{- partial "icon" "arrow_outward" -}}
</a>
Expand Down
11 changes: 11 additions & 0 deletions layouts/shortcodes/link.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{{- $url := .Get "url" -}}
{{- $text := .Get "text" -}}
{{- $arialabel := .Get "arialabel" -}}

{{- partial "link"
(dict
"Destination" $url
"Text" $text
"Arialabel" $arialabel
)
-}}
2 changes: 2 additions & 0 deletions layouts/shortcodes/team-members.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@
<div class="m-team-member__info">
<div class="m-team-member__name">
{{- if .link -}}
{{ $arialabel := print $name " " (T "teamMembers.linkedin") }}
{{ partial "link"
(dict
"Destination" .link
"Arialabel" $arialabel
"Text" $name
)
}}
Expand Down
Loading