Skip to content

Conversation

@therobrob
Copy link
Member

don’t render o-booking__classes if there is no content

Resolves #546

@therobrob therobrob added bug Something isn't working technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. labels Jan 10, 2026
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link

netlify bot commented Jan 10, 2026

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit f826435
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/696fb9244e8bb800087bb25b
😎 Deploy Preview https://deploy-preview-598--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0
Copy link
Member

The div is no longer rendered, so that's good, but the free space doesn't seem to be used by the o-booking__meta div, so the text still wraps.

grafik

@therobrob
Copy link
Member Author

The div is no longer rendered, so that's good, but the free space doesn't seem to be used by the o-booking__meta div, so the text still wraps.

That’s absolutely intended, see #546 (comment) :)

MoritzWeber0
MoritzWeber0 previously approved these changes Jan 18, 2026
@therobrob
Copy link
Member Author

therobrob commented Jan 20, 2026

@MoritzWeber0 do you wanna merge #615 into this one before merging it? 🤔

@MoritzWeber0 MoritzWeber0 merged commit 9d47a3d into main Jan 20, 2026
7 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix/546-booking-expander-renders-always-three-columns branch January 20, 2026 17:53
@MoritzWeber0
Copy link
Member

@MoritzWeber0 do you wanna merge #615 into this one before merging it? 🤔

No, I just had to wait for the pipeline to be green :)

@therobrob
Copy link
Member Author

@MoritzWeber0 do you wanna merge #615 into this one before merging it? 🤔

No, I just had to wait for the pipeline to be green :)

Mhm I don’t get it.. the base branch of #615 was this PR, now we have merge conflicts. But do it your way, it’s fine for me in both ways :D

@MoritzWeber0
Copy link
Member

@MoritzWeber0 do you wanna merge #615 into this one before merging it? 🤔

No, I just had to wait for the pipeline to be green :)

Mhm I don’t get it.. the base branch of #615 was this PR, now we have merge conflicts. But do it your way, it’s fine for me in both ways :D

Ahh, yeah, that's because of the squashed commits. But they're easy to resolve with an interactive rebase. I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Booking expander renders always three columns

3 participants