Repository navigation
Audit remediation: project_id and minimised event reads - #1
Merged
Merged
Conversation
Follows server ADR 0022: event reads return the visitor's /24 or /40 network instead of the address, no longer return the deferred report, and the document is an allow-listed view. Refreshes the contract snapshot (server 717227a).
Conflicts: Event.java keeps getProjectId() and getIpNetwork() and drops getIpAddress(); the changelog keeps one Unreleased entry for both ADRs; contract/manifest.json records the hashes of the merged openapi.json and fixtures.json, which carry both project_id and ip_network (serverCommit stays at ADR 0022's 717227a until the re-sync).
Re-synced with tools/SyncContract.java from the sdks integration contract (server integration/audit-remediation e22f967). The event read shape is unchanged; the OpenAPI gains the project management, usage, attestation-credential and DeviceCheck routes and the ADR 0027 429 descriptions. fixtures.json was already identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings this SDK in line with the server's audit remediation (fingerly-io/server#3):
project_id. Docs describe webhookdata.project_idand warn thattagmust never carry a personal identifier.ip_network(IPv4 /24, IPv6 /40) instead of the rawip_address.deferred_signalsis removed, anddocumentis now an allow-listed view rather than the raw archived report.Testing
The repository's own format, lint, test and package checks pass. A scan of the diff found no secrets or personal data.
Release notes
Release after the server release is deployed. The previous
ip_addressfield is gone; there are no existing users.