Skip to content

Audit remediation: project_id and minimised event reads - #1

Merged
hasan-muzak merged 5 commits into
mainfrom
integration/audit-remediation
Nov 12, 2026
Merged

hasan-muzak merged 5 commits into
mainfrom
integration/audit-remediation

Conversation

@hasan-muzak

Copy link
Copy Markdown
Contributor

Summary

Brings this SDK in line with the server's audit remediation (fingerly-io/server#3):

  • ADR 0023 per-project tenancy: events carry an optional project_id. Docs describe webhook data.project_id and warn that tag must never carry a personal identifier.
  • ADR 0022 data minimisation: event reads return ip_network (IPv4 /24, IPv6 /40) instead of the raw ip_address. deferred_signals is removed, and document is now an allow-listed view rather than the raw archived report.
  • The vendored contract snapshot is refreshed from the server integration branch (e22f967).

Testing

The repository's own format, lint, test and package checks pass. A scan of the diff found no secrets or personal data.

Release notes

Release after the server release is deployed. The previous ip_address field is gone; there are no existing users.

Follows server ADR 0022: event reads return the visitor's /24 or /40
network instead of the address, no longer return the deferred report,
and the document is an allow-listed view. Refreshes the contract
snapshot (server 717227a).
Conflicts: Event.java keeps getProjectId() and getIpNetwork() and drops
getIpAddress(); the changelog keeps one Unreleased entry for both ADRs;
contract/manifest.json records the hashes of the merged openapi.json and
fixtures.json, which carry both project_id and ip_network (serverCommit
stays at ADR 0022's 717227a until the re-sync).
Re-synced with tools/SyncContract.java from the sdks integration contract (server integration/audit-remediation e22f967). The event read shape is unchanged; the OpenAPI gains the project management, usage, attestation-credential and DeviceCheck routes and the ADR 0027 429 descriptions. fixtures.json was already identical.
@hasan-muzak
hasan-muzak merged commit b75e6b1 into main Nov 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant