Repository navigation
Fix slice offsets outside the signed 32-bit range - #378
Open
Huzaifa-Asif wants to merge 1 commit into
Open
Huzaifa-Asif wants to merge 1 commit into
Huzaifa-Asif wants to merge 1 commit into
Conversation
Huzaifa-Asif
marked this pull request as ready for review
October 7, 2026 02:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315.
Buffer.prototype.slicecurrently convertsstartandendwith~~, which wraps large offsets to signed 32-bit values. For example,Buffer.from([1, 2, 3]).slice(1, 2 ** 32)returns an empty buffer instead of[2, 3].Replace those two coercions with
Math.trunc, preserving the existing bounds adjustment and shared-memory view. Regression coverage includes large positive and negative offsets, fractional and non-finite values, string/object coercion, and nested slice aliasing. The new tests produce 22 failing assertions before the fix; all 60 focused slice assertions pass afterward.Verification
npm test: 1,048,618 assertions passed during preparation on Node 18, 20, 22, and 24git diff --checkpassAI assistance disclosure
OpenAI Codex assisted with investigation, implementation, tests, review, and drafting this description. No human-review attestation is made.