Repository navigation
chore: support Node 22 and newer - #226
Merged
Merged
Conversation
Widen engines.node from >=24 <25 to >=22 and run the unit test job on Node 22, 24, and the latest release. Refs fells-code/seamless-auth-api#339.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fells-code/seamless-auth-api#339.
What changed
engines.nodegoes from>=24 <25to>=22(package.json and package-lock.json; the lockfile also catches up to the current 0.18.0 version).Build and unit testjob runs on a Node matrix of 22, 24, andlatest, withfail-fast: false. Release, scaffold smoke, and verify conformance workflows stay on Node 24.Verification
Run locally on Node 22.21.0, 24.18.0, and 26.10.0:
check:types-current, build,npm test(56 files, 1076 tests). All pass on every version. The builtseamless --helpalso runs on Node 22.Release note
@seamless-auth/types@0.26.0still declares>=24 <25, sonpm cion Node 22 warns until fells-code/seamless-auth-types#88 ships and this repo bumps to it.