Repository navigation
docs: state that only express is linked with core for releases - #200
Merged
Merged
Conversation
README.md and RELEASES.md said the core and official JavaScript adapters are linked in .changeset/config.json. The config links only @seamless-auth/core and @seamless-auth/express; @seamless-auth/fastify and @seamless-auth/nextjs release on their own versions. Reword both files to describe the actual policy, and adjust the RELEASES.md pre-1.0 and after-v1 bullets so they refer to express rather than all adapters. The changeset config is unchanged; whether to link the other adapters is a separate release-policy decision. Closes #195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md and RELEASES.md said "The core and official JavaScript adapters are linked".
.changeset/config.jsonlinks only["@seamless-auth/core", "@seamless-auth/express"], and the versions show it: core and express are 0.19.1, fastify 0.10.1, nextjs 0.3.1.The changeset config is unchanged. Whether to link fastify and nextjs too is a release-policy decision for maintainers.
Docs only, no changeset.
Testing
pnpm install --frozen-lockfile,pnpm check:types-current, andpnpm testpass (core 342, express 203, nextjs 155, fastify 146).Closes #195