fix: register with just an email#41
Merged
Merged
Conversation
Make the phone optional on the registration form (validated only when provided) and route a successful registration to email verification instead of phone verification, matching the auth server's email-first registration flow. The user is signed in after verifying the email code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Let users register with just an email, matching the auth server's email-first
registration flow.
Why
Registration required both email and phone, and a successful register navigated to
/verifyPhoneOTP— but the server sends an email OTP on registration and (now) issuesthe session once the email is verified. The phone-first UI left users stranded on a phone
screen with no SMS sent. (Surfaced by the
seamless verifyconformance harness.)Changes
/verifyEmailOTP; verifying the email code signsthe user in.
Verification
npx jestgreen (147 tests).seamless verify --localgreen, including a new browser case:register with just an email -> verify email OTP -> signed in.Pairs with fells-code/seamless-auth-server (registration session cookies).