feat(oauth): passkey enrollment after a legacy provider sign-in - #156
Merged
Merged
Conversation
Route nextStep: 'enroll_passkey' from the OAuth callback into passkey enrollment, carrying returnTo through it, and recognise the oauth_provider_retired and oauth_invalid_id_token codes. Part of fells-code/seamless-auth-api#337.
Bccorb
force-pushed
the
feat/oauth-cutover
branch
from
October 6, 2026 01:36
604a361 to
8bb6371
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fells-code/seamless-auth-api#337 (epic fells-code/seamless-auth-api#334). Client side of fells-code/seamless-auth-api#346.
Changes
@seamless-auth/typesgoes from ^0.20.0 to ^0.25.0 inclient,reactandreact-native. Nothing else needed changing for the jump.getOAuthErrorCoderecognisesoauth_provider_retiredandoauth_invalid_id_token. The exhaustiveRecord<OAuthErrorCode, …>maps would not compile without them.OAuthCallbacksends the user to/register-passkeywhen the sign-in response carriesnextStep: 'enroll_passkey'. The API only sends it for providers withpromptPasskeyEnrollmentset, and only when the user has no passkey. The in-appreturnTogoes along in router state./. Only an in-app path is followed://host,/\host, absolute URLs and non-strings fall back to/.Checks
From a clean
npm ci: lint, typecheck, format:check,npm test -- --runInBand(37 suites, 434 tests), build and check-npm-build all pass.verify / verifywill fail for a reason outside this PR. The conformance run buildsseamless-templates' react-vite template against Reactmain, and that template still importsAuthRoutesfrom the package root, which #153 moved to@seamless-auth/react/routes. The template can only switch once a React release with/routesis published.