fix(oauth): apply provider schema defaults from OAUTH_PROVIDERS env#50
Merged
Conversation
OAUTH_PROVIDERS was parsed with a raw JSON.parse, so per-provider defaults (subjectJsonPath, emailJsonPath, ...) were never applied and OAuth profile extraction failed silently. Validate the env value through the schema, and log the underlying error in the callback catch. Fixes #49.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Jun 29, 2026
feat(oauth): add provider buttons + callback route to auth screens
fells-code/seamless-auth-react#44
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49.
Problem
OAuth login configured via
OAUTH_PROVIDERSfailed with a generic400 "OAuth login failed"unless every provider explicitly set
subjectJsonPath/emailJsonPath/emailVerifiedJsonPath.parseEnvConfigsparsed the value with a rawJSON.parse, so theOAuthProviderConfigSchemadefaults for those fields were never applied.
getJsonPathValuereturnsundefinedfor afalsy path, so profile extraction yielded nothing and
fetchOAuthProfilethrew"OAuth profile did not include a provider subject".
Fix
oauth_providersthroughz.array(OAuthProviderConfigSchema)so per-provider defaultsare applied (and invalid entries fail fast at startup).
finishOAuthLogincatch, which previously swallowed it.Tests
parseSystemConfigEnvValuecases: defaults are applied to a minimal provider; an invalidprovider entry throws.
Found by the
seamless verifyconformance harness (mock-OIDC OAuth case).