Repository navigation
fix(routes): mark registration routes that support external delivery - #382
Merged
Merged
Conversation
/registration/register and /registration/phone return a delivery payload when external delivery is requested, so adapters must deliver it rather than pass it to the browser. A route that declares delivery now has to have a success response that can carry one. The reverse is not checked, because the shared MessageSchema allows a delivery payload on routes that never send one.
Bccorb
added a commit
to fells-code/seamless-auth-server
that referenced
this pull request
Oct 8, 2026
The bundled copy was generated before fells-code/seamless-auth-api#382 merged, so it did not mark /registration/register and /registration/phone as delivery routes. Regenerated from the API's main branch. Co-authored-by: Brandon Corbett <Bccorb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #380, which was squash-merged before this commit reached it. Part of #371.
Why
/registration/registerand/registration/phonereturn a delivery payload when a caller asks for external delivery, but the adapter manifest did not mark them asdeliveryroutes. An adapter following the manifest would then pass the message to the browser instead of sending it, or never ask for external delivery at all.What changes
adapter: { delivery: true }(register keepsissues: 'registration'), andadapter-manifest.jsonis regenerated.deliverymust have a success response that can carry a delivery payload, so a declaration cannot drift from the schema. The reverse is not checked: the sharedMessageSchemaallows a delivery payload on routes that never send one.No route changes shape. The changeset from #380 already covers the manifest. fells-code/seamless-auth-server#201 bundles a copy of the manifest and will be resynced once this merges.
Checks
npm run typecheck,npm run lintandnpm run format:checkare clean.npm run test:run: 135 files, 1796 passed.