Skip to content

Fix incorrect precision example in GeometricWidthDiscretiser docs #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maupatel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect precision example in GeometricWidthDiscretiser docs #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/user_guide/discretisation/GeometricWidthDiscretiser.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ This discretisation technique is great when the distribution of the variable is
to work properly, it might help to increase the precision value, that is,
the number of decimal values allowed to define each bin. If the variable has a
narrow range or you are sorting into several bins, allow greater precision
(i.e., if precision = 3, then 0.001; if precision = 7, then 0.0001).
(i.e., if precision = 3, then 0.001; if precision = 7, then 0.0000001).

:class:`GeometricWidthDiscretiser()` works only with numerical variables. A list of
variables to discretise can be indicated, or the discretiser will automatically select
Expand Down
2 changes: 1 addition & 1 deletion feature_engine/discretisation/geometric_width.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class GeometricWidthDiscretiser(BaseDiscretiser):
to work properly, it might help to increase the precision value, that is,
the number of decimal values allowed to define each bin. If the variable has a
narrow range or you are sorting into several bins, allow greater precision
(i.e., if precision = 3, then 0.001; if precision = 7, then 0.0001).
(i.e., if precision = 3, then 0.001; if precision = 7, then 0.0000001).

The :class:`GeometricWidthDiscretiser()` works only with numerical variables.
A list of variables to discretise can be indicated, or the discretiser will
Expand Down