fix: Support SQL registry dump - #6770
Open
tandede wants to merge 2 commits into
Open
Conversation
Signed-off-by: tandede <1090179959@qq.com>
tandede
marked this pull request as ready for review
August 21, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feast registry-dumpalways instantiated the file-backedRegistrydirectly. As a result, a valid SQL registry URL such aspostgresql+psycopg://...was parsed as if it were an object-storage URI and rejected as an unsupported scheme before any registry data could be read.This change routes
registry-dumpthroughFeatureStore.registry, the same backend-selection path used by the rest of Feast. SQL, Snowflake, remote, and file-backed registries therefore use their configured implementations, while the repository path is still supplied for relative file registry paths.The regression test creates a real SQLite-backed SQL registry, writes an entity through
SqlRegistry, and verifies thatregistry_dump()reads the entity back as JSON. The test fails onmasterwithunsupported scheme sqliteand passes with this change.Which issue(s) this PR fixes:
Fixes #6764
Checks
git commit -s)Testing Strategy
Tests and checks run:
python -m pytest -q sdk/python/tests/unit/test_repo_operations_registry_dump.py sdk/python/tests/unit/infra/registry/test_sql_registry.py sdk/python/tests/unit/test_registry_string_config.py sdk/python/tests/unit/cli/test_cli_chdir.py(41 passed)python -m pytest -q -n 0 sdk/python/tests/unit/cli sdk/python/tests/unit/test_repo_operations_registry_dump.py sdk/python/tests/unit/test_repo_operations_validate_feast_project_name.py sdk/python/tests/unit/infra/scaffolding/test_repo_operations.py(15 passed)pre-commit run --files sdk/python/feast/repo_operations.py sdk/python/tests/unit/test_repo_operations_registry_dump.pymypy feast/repo_operations.pyMisc
No documentation changes are needed because this restores the documented backend-independent behavior of
registry-dump.