ci: Enforce local linting and commit conventions via pre-commit hooks#6335
Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Open
ci: Enforce local linting and commit conventions via pre-commit hooks#6335ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
70354bf to
8039384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Contributors could push code and open PRs without any local linting or
commit message validation if they hadn't manually installed pre-commit
hooks. Specifically:
make install-python-dependencies-dev(the standard dev setup command)did not install pre-commit hooks, so most contributors never had
them active.
make install-precommitonly registered thepre-commithook type,meaning the
commitlinthook (which requirescommit-msgstage) andany push-time checks were never wired up — even for contributors who
ran
make install-precommitexplicitly.even if the commit-time hook was bypassed (e.g.
--no-verify).