Skip to content

ci: Enforce local linting and commit conventions via pre-commit hooks#6335

Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole:local_lint_enforce
Open

ci: Enforce local linting and commit conventions via pre-commit hooks#6335
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole:local_lint_enforce

Conversation

@ntkathole
Copy link
Copy Markdown
Member

@ntkathole ntkathole commented Apr 26, 2026

What this PR does / why we need it:

Contributors could push code and open PRs without any local linting or
commit message validation if they hadn't manually installed pre-commit
hooks. Specifically:

  • make install-python-dependencies-dev (the standard dev setup command)
    did not install pre-commit hooks, so most contributors never had
    them active.
  • make install-precommit only registered the pre-commit hook type,
    meaning the commitlint hook (which requires commit-msg stage) and
    any push-time checks were never wired up — even for contributors who
    ran make install-precommit explicitly.
  • There was no push-time gate, so bad formatting could reach the remote
    even if the commit-time hook was bypassed (e.g. --no-verify).

Open in Devin Review

@ntkathole ntkathole self-assigned this Apr 26, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant