fix: Add project filter to apply_data_source and delete_data_source (closes #6206)#6322
Open
mailtoboggavarapu-coder wants to merge 4 commits intofeast-dev:masterfrom
Open
fix: Add project filter to apply_data_source and delete_data_source (closes #6206)#6322mailtoboggavarapu-coder wants to merge 4 commits intofeast-dev:masterfrom
mailtoboggavarapu-coder wants to merge 4 commits intofeast-dev:masterfrom
Conversation
…ixes feast-dev#6206) Filters existing data sources by both name and project in the file registry implementation, fixing cross-project contamination (issue feast-dev#6206). Changes: - apply_data_source: added project-scoped deduplication check - delete_data_source: added project filter to avoid cross-project deletion Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Regression tests for feast-dev#6206: - test_apply_data_source_cross_project_isolation: verifies applying a data source to project_a does not overwrite the same-named source in project_b - test_delete_data_source_project_scoped: verifies delete_data_source only removes the source from the specified project Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Author
|
Hi team! Checking in on this PR which fixes the missing project filter in Quick status update:
Happy to address any feedback or make changes. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cross-project data source contamination in the file registry (issue #6206).
Root cause:
apply_data_sourceonly matched onname, notproject, so applying a data source in project B could overwrite an existing source with the same name in project A.Changes:
apply_data_source: deduplication now checks bothnameANDprojectdelete_data_source: deletion now filters by bothnameANDprojectTests added:
test_apply_data_source_cross_project_isolation: verifies project-scoped deduplicationtest_delete_data_source_project_scoped: verifies project-scoped deletionCloses #6206