feat: Add optional 'org' in feature view (#6288)#6301
Open
nquinn408 wants to merge 6 commits intofeast-dev:masterfrom
Open
feat: Add optional 'org' in feature view (#6288)#6301nquinn408 wants to merge 6 commits intofeast-dev:masterfrom
nquinn408 wants to merge 6 commits intofeast-dev:masterfrom
Conversation
nquinn408
changed the title
nquinn408
force-pushed
the
add-optional-org
branch
from
6936cd9 to
1054d4a
Compare
nquinn408
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 Compiled Python protobuf files not regenerated after adding org field to FeatureView.proto (sdk/python/feast/protos/feast/core/FeatureView_pb2.py:22)
The .proto file adds string org = 19 to FeatureViewSpec, but the compiled Python protobuf files (FeatureView_pb2.py and FeatureView_pb2.pyi) were not regenerated. The FeatureView_pb2.pyi shows no ORG_FIELD_NUMBER, no org attribute, and no org parameter in __init__. The serialized descriptor in FeatureView_pb2.py still only covers fields up to version (field 18).
This causes runtime failures in two places:
to_proto_spec()atsdk/python/feast/feature_view.py:495passesorg=self.orgtoFeatureViewSpecProto(...), which will raiseValueErrorbecause the proto descriptor doesn't know aboutorg._from_proto_internal()atsdk/python/feast/feature_view.py:622andsdk/python/feast/feature_view.py:645readsfeature_view_proto.spec.org, which will raiseAttributeError.
This also violates the AGENTS.md rule: "Recompile protos after making changes to .proto files."
View 3 additional findings in Devin Review.
nquinn408
force-pushed
the
add-optional-org
branch
6 times, most recently
from
1c01636 to
e1b4786
Compare
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
nquinn408
force-pushed
the
add-optional-org
branch
from
e1b4786 to
9a94a3f
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
nquinn408
force-pushed
the
add-optional-org
branch
from
267cc27 to
b15ced3
Compare
franciscojavierarceo
approved these changes
Apr 26, 2026
ntkathole
reviewed
Apr 26, 2026
| owner: The owner of the on demand feature view, typically the email of the primary | ||
| maintainer. | ||
| org: The organizational unit that owns this on demand feature view (e.g. "ads", | ||
| "search"). Defaults to empty string. |
Member
There was a problem hiding this comment.
don't we want same for StreamFeatureView as well ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.