fix: Add avg alias and fix aggregation group_by_keys#6294
Open
cutoutsy wants to merge 1 commit intofeast-dev:masterfrom
Open
fix: Add avg alias and fix aggregation group_by_keys#6294cutoutsy wants to merge 1 commit intofeast-dev:masterfrom
cutoutsy wants to merge 1 commit intofeast-dev:masterfrom
Conversation
cutoutsy
force-pushed
the
fix/aggregation-alias-and-aggregation-by-keys
branch
from
e40e3ba to
521e742
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add "avg" -> "mean" function alias for aggregation - Fix group_by_keys retrieval in LocalFeatureBuilder to use column_info.join_keys Signed-off-by: cutoutsy <cutoutsy@gmail.com>
ntkathole
force-pushed
the
fix/aggregation-alias-and-aggregation-by-keys
branch
from
521e742 to
2126ace
Compare
ntkathole
reviewed
Apr 22, 2026
| ) | ||
| group_by_keys = view.entities | ||
| column_info = self.get_column_info(view) | ||
| group_by_keys = column_info.join_keys |
Member
There was a problem hiding this comment.
looks like both Spark and Ray build_aggregation_node implementations have the identical issue ?
@cutoutsy can we fix it as well ?
Member
|
Let's have a test case as well ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.