Skip to content

ci: Upgrade deprecated GitHub Actions to current major versions#6293

Open
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole:fix_aws_cred
Open

ci: Upgrade deprecated GitHub Actions to current major versions#6293
ntkathole wants to merge 1 commit intofeast-dev:masterfrom
ntkathole:fix_aws_cred

Conversation

@ntkathole
Copy link
Copy Markdown
Member

@ntkathole ntkathole commented Apr 17, 2026

What this PR does / why we need it:

ci: upgrade deprecated GitHub Actions to current major versions

Summary

  • Upgrade all deprecated GitHub Actions across CI workflows to their current stable major versions
  • Primary fix: aws-actions/configure-aws-credentials@v1@v4, which resolves flaky test_push_features_and_read_async DynamoDB integration test failures caused by unreliable credential propagation from the deprecated action

Problem

The pr-integration-tests workflow uses aws-actions/configure-aws-credentials@v1, which relies on the deprecated ::set-output command for internal credential handling. GitHub is actively disabling this mechanism, causing intermittent credential propagation failures. This manifests as a flaky UnrecognizedClientException: The security token included in the request is invalid error specifically in the async DynamoDB test path, because:

  • The sync boto3 client caches credentials at the class level (initialized once during store.apply() and reused)
  • The async aiobotocore client creates a fresh session per instance, re-resolving credentials from the environment each time — making it sensitive to the degraded v1 action output

Additionally, the CI annotations flag multiple deprecated actions across workflows that will be force-migrated to Node.js 24 by GitHub starting June 2nd, 2026.

Changes

Action Old New Files
aws-actions/configure-aws-credentials @v1 @v4 5 workflows
google-github-actions/auth @v1 @v2 7 workflows
google-github-actions/setup-gcloud @v1 @v2 7 workflows
actions/setup-go @v2 @v5 5 workflows
actions/setup-node @v3 @v4 4 workflows
github/codeql-action/* @v3 @v4 1 workflow
actions/upload-pages-artifact @v3 @v4 1 workflow

All inputs used by the workflows (aws-access-key-id, credentials_json, project_id, go-version, node-version, etc.) are confirmed compatible with the new versions — no workflow configuration changes required beyond the version bumps.

Test plan

  • pr-integration-tests passes, specifically test_push_features_and_read_async[...dynamodb...]
  • pr-registration-integration-tests passes
  • pr-local-integration-tests passes (unaffected, uses no cloud credentials)
  • No set-output or Node.js deprecation warnings in CI annotations

Open with Devin

@ntkathole ntkathole self-assigned this Apr 17, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@ntkathole ntkathole force-pushed the fix_aws_cred branch 2 times, most recently from 5e5bfa6 to bec3865 Compare April 17, 2026 12:51
@ntkathole ntkathole requested a review from a team as a code owner April 17, 2026 12:51
devin-ai-integration[bot]

This comment was marked as resolved.

@ntkathole ntkathole force-pushed the fix_aws_cred branch 2 times, most recently from f5f30ae to 12abd5e Compare April 17, 2026 13:31
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant