Repository navigation
Version 0.6.0: the spec at API 1.20.0, email_pdf added, cost fields removed - #12
Merged
Merged
Conversation
…emoved The saved spec follows the public document at API 1.20.0. Number and NumberUpdate carry email_pdf. numbers.update sends it only when given. Extraction.provider_cost_micro and ExtractionPage.cost_micro are removed. The server stopped sending both at API 1.19.0. 0.5.0 required provider_cost_micro, so an extraction from the current API failed to parse. Tests cover the email_pdf body, an older number and an extraction without the cost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows API 1.20.0. The saved spec takes the changes of faxforagents/openapi#10 and the models are regenerated from it.
Added
Number.email_pdf, a boolean. A number from an older server reads it asFalse.NumberUpdate.email_pdf.numbers.update(number_id, email_pdf=True)sends it, on both clients.Falseis sent and switches the attachment off.Removed (breaking)
Extraction.provider_cost_micro. The server stopped sending it at API 1.19.0.ExtractionPage.cost_micro, an SDK-declared field the server stopped sending at the same release.Fixed
0.5.0 required
provider_cost_micro. Every extraction, classification and summary call failed to parse on API 1.19.0 and later.Version
0.6.0. A removed model field is a breaking change. Earlier breaking releases of this 0.x package raised the minor number (0.4.0, 0.5.0).
Checks run
pytest -q -m "not live": 146 passed.ruff check,ruff format --check,mypy src.python scripts/gen_models.py --check.sh scripts/truthcheck.sh.python -m buildandtwine check.The live test needs a test key and did not run here.