Add union introspection compatibility tests#81
Merged
Conversation
Collapse hand-formatted multi-line decorators and the parametrize list onto single lines so `ruff format --check` passes. No behavior change; all 12 contract tests still pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lt14zRDjGJv9YU9QZC3PqY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_union,is_optional,remove_optional, and_remove_optional.typing.Unionand PEP 604 (X | Y) syntax.Why
Mode issue #80 exposed a downstream compatibility boundary: Mode 0.5.3 correctly recognizes PEP 604 unions that 0.4.1 did not recognize. These tests make that behavior explicit so future changes cannot silently alter the annotation shape downstream projects receive.
This PR does not change Mode runtime behavior; the reported exception is raised later by Faust's type-expression compiler.