Skip to content

IIRR-38: Collapse Rejected table by default, move to the bottom #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuanVqz merged 1 commit into from
Jun 4, 2026
+15 −3
Merged

IIRR-38: Collapse Rejected table by default, move to the bottom #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/assets/stylesheets/application.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,15 @@ td pre {
margin-bottom: 1rem;
}

.rejected_table {
summary {
display: list-item;
Copy link
Copy Markdown
Contributor Author

@arielj arielj Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the original display value for the summary elements, the styleguide is overriding it and the little arrow gets lost without this.

text-align: start;
padding-inline-start: 1rem;
}
padding-block: 2rem;
}

/* Banner styles - using styleguide colors where possible */
.banner {
position: fixed;
Expand Down
9 changes: 6 additions & 3 deletions app/views/puzzles/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
</h1>
<%= render partial: 'puzzles_table', locals: { puzzles: @approved_puzzles, actions: :approved } %>

<h1>Rejected Puzzles</h1>
<%= render partial: 'puzzles_table', locals: { puzzles: @rejected_puzzles, actions: :rejected } %>

<h1>Archive Puzzles - Total: <%= @archived_puzzles.length %></h1>
<p>These puzzles have already been sent to the users.</p>
<section class="filters">
Expand All @@ -24,3 +21,9 @@
<%= link_to "Hide cloned puzzles", url_for(hide_cloned_puzzles: true, low_success_rate: params[:low_success_rate]) %>
</section>
<%= render partial: 'puzzles_table', locals: { puzzles: @archived_puzzles, actions: :archived } %>

<details class="rejected_table">
<summary>Click to expand/collapse "Rejected Puzzles" table</summary>
<h1>Rejected Puzzles</h1>
<%= render partial: 'puzzles_table', locals: { puzzles: @rejected_puzzles, actions: :rejected } %>
</details>