Skip to content

DT-457: Add ability to select all stories in a project#331

Merged
JuanVqz merged 6 commits into
mainfrom
feature/DT-457-add-select-all
Jul 21, 2026
Merged

DT-457: Add ability to select all stories in a project#331
JuanVqz merged 6 commits into
mainfrom
feature/DT-457-add-select-all

Conversation

@torresga

@torresga torresga commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

Jira Ticket

See https://ombulabs.atlassian.net/browse/DT-457

Motivation / Context

In a Points project, stories need to be selected individually. There is no option to select all. There should be a Select All option to be able to easily perform bulk actions.

QA / Testing Instructions

  1. Go to a project with stories
  2. Check the Select All checkbox
  3. Ensure that all stories are selected and Bulk Delete button becomes enabled and shows the number of all stories selected
  4. Unselect the Select All checkbox
  5. Ensure that no stories are selected and the Bulk Delete button is disabled

Screenshots:

Screenshot 2024-10-21 at 10 07 19 AM Screenshot 2024-10-21 at 10 07 12 AM

Note:

  • app/models/user.rb was changed here because there were some linting issues standardrb wouldn’t let me commit without.
  • I also realize the CI for this is failing - I did add a PR for this change in another PR DT-459: Updates upload-artifact #332 and then cherry-picked the change in this PR to ensure CI passed.

I will abide by the code of conduct.

@torresga
torresga changed the base branch from main to fix/updates-upload-artifacts-in-build-rails-current October 21, 2024 18:02
@torresga
torresga force-pushed the feature/DT-457-add-select-all branch from de007bb to 5fd55b2 Compare October 21, 2024 18:17
@torresga
torresga changed the base branch from fix/updates-upload-artifacts-in-build-rails-current to main October 21, 2024 18:27
@torresga
torresga force-pushed the feature/DT-457-add-select-all branch from 5fd55b2 to de007bb Compare October 21, 2024 18:55
@JuanVqz
JuanVqz force-pushed the feature/DT-457-add-select-all branch from 8ec1738 to 8df2bbf Compare July 21, 2026 00:02
@JuanVqz
JuanVqz force-pushed the feature/DT-457-add-select-all branch from 8df2bbf to d49d5bc Compare July 21, 2026 18:08
torresga and others added 5 commits July 21, 2026 13:59
- Only render the Select All checkbox when the project is unlocked, matching
  Add a Story and the bulk-delete control (addresses the review question about
  the unlocked check). Add a spec that it is hidden on a locked project.
- Make updateSelectAllStatus null-safe so toggling a row checkbox on a locked
  project (where Select All is absent) no longer throws.
- Clean up the extracted updateBulkDeleteStatus indentation and file newline.
- De-flake the madmin projects spec via CGI.escapeHTML (same fix as PR #333).
… selected

Documents that updateBulkDeleteStatus's unlocked guard is load-bearing: story
checkboxes still render on locked projects, so without the guard, selecting a
story would enable Bulk Delete.
@JuanVqz
JuanVqz force-pushed the feature/DT-457-add-select-all branch from d49d5bc to e959200 Compare July 21, 2026 20:11
Give the checkboxes their own column with a bold 'Select All' header, instead
of tucking the control into the right-hand actions cell where it was hard to
find. Add the sixth grid track for the new column and shift the story-title
filter and estimate-position helper to account for it.
@JuanVqz

JuanVqz commented Jul 21, 2026

Copy link
Copy Markdown
Member

ended up moving the Select All checkbox into its own column because it was messy.

Screenshot 2026-07-21 at 14 28 29

@JuanVqz
JuanVqz merged commit 6453697 into main Jul 21, 2026
2 checks passed
@JuanVqz
JuanVqz deleted the feature/DT-457-add-select-all branch July 21, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants