chore: move used vendored packages into philo, strip posthog#10
Open
ComputelessComputer wants to merge 13 commits intomainfrom
Open
chore: move used vendored packages into philo, strip posthog#10ComputelessComputer wants to merge 13 commits intomainfrom
ComputelessComputer wants to merge 13 commits intomainfrom
Conversation
Restored: data, s3, docs, transcribe-whisper-local, whisper-local, pyannote-local. These are pulled in transitively by kept crates and were missing from the initial inventory. cargo metadata now resolves cleanly.
- Delete crates/analytics and plugins/analytics - Remove tauri-plugin-analytics + hypr-analytics + posthog-rs from root workspace deps - Remove tauri-plugin-analytics dep + plugin registration + 2 event_fire_and_forget calls from apps/desktop/src-tauri/src/lib.rs - Remove analytics:default permission from default.json - Remove tauri-plugin-analytics dep from apps/desktop/src-tauri/Cargo.toml - Remove analytics block from plugins/windows show_main_window - Delete apps/desktop/src/services/analytics.ts and all trackEvent call sites across desktop UI
- Remove vendor/hyprnote git submodule and .gitmodules - Drop "!vendor/**" from pnpm-workspace.yaml - Rewrite apps/desktop/src-tauri/build.rs swift path to plugins/permissions/... - Update docs/repo-structure.md to describe crates/ and plugins/ instead of vendor/ - Regenerate pnpm-lock.yaml
- dprint fmt on TS/JSON/MD across all owned crates and plugins - cargo fmt --all - Drop the unused 'source' parameter from handleDeletePage left over from trackEvent removal
cargo metadata during the workspace setup created target/ which got captured by 'git add -A'. Add target/ to .gitignore and untrack.
Vendored helper has 8 args; refactoring is out of scope for the vendor- move PR. Suppresses the only clippy::too_many_arguments error blocking CI rust job.
cactus-sys/build.rs needs C source at vendor/cactus/cactus/. Was nested inside the deleted vendor/hyprnote/ submodule; restoring as direct submodule pinned to upstream commit 89cd7476 (matches the SHA hyprnote was using). Required for cactus-sys build to succeed locally on macOS.
CI runs on ubuntu so these never fired upstream. They surface on macOS local builds. Suppressing rather than refactoring vendored code: - crates/cactus: too_many_arguments on run_transcribe_worker - crates/device-monitor: collapsible_if in macos.rs - crates/mac: needless_range_loop crate-level - crates/transcribe-cactus: too_many_arguments + collapsible_if + needless_range_loop crate-level - plugins/local-stt: needless_return crate-level (cfg-conditional)
Apply dprint formatting to permission schemas + reference markdown that were autogenerated by build scripts during the vendor hoist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
vendor/hyprnote/intocrates/andplugins/at the repo root (48 crates + 17 plugins)./Cargo.toml,rust-toolchain.toml,.cargo/config.toml).vendor/entirely (was a git submodule pointing atfastrepl/hyprnote); removes.gitmodulesand the!vendor/**line inpnpm-workspace.yaml.apps/desktop/src/services/analytics.tsand everytrackEventcall site across desktop UI (OnboardingModal,EditorBubbleMenu,WidgetExtension,WidgetView,AppLayout,EditableNote).tauri-plugin-analyticsdep, plugin registration, and 2event_fire_and_forgetinvocations fromapps/desktop/src-tauri/src/lib.rs(show_main_window,app_started).crates/analytics,plugins/analytics, removed theshow_main_windowanalytics block inplugins/windows/src/ext.rs, and removedtauri-plugin-analyticsfromplugins/windows/Cargo.toml.hypr-analytics,tauri-plugin-analytics,posthog-rsfrom rootCargo.toml's[workspace.dependencies].analytics:defaultfromapps/desktop/src-tauri/capabilities/default.json.apps/desktop/package.jsonorpackages/*/package.json— all posthog references lived insidevendor/and were deleted with it.Why
John's call — strip telemetry from the desktop app, take ownership of the Rust crates and plugins philo actually uses, drop the rest. Reduces repo surface area significantly and removes a git submodule.
Notes / Judgment Calls
data,s3,docs,transcribe-whisper-local,whisper-local,pyannote-local(committed separately aschore: restore 6 transitive vendored crates needed by dep graph).apps/desktop/src-tauri/build.rshad avendor/hyprnote/plugins/permissions/swift/...path; rewritten toplugins/permissions/swift/....docs/repo-structure.mdupdated to describe the newcrates/andplugins/layout instead ofvendor/.sourceparameter fromhandleDeletePageinAppLayout.tsx(left dangling after the trackEvent strip — caught by typecheck).target/entry in.gitignore; runningcargo metadatamaterialisedtarget/and the firstgit add -Aswept it in. Addedtarget/to.gitignoreand removed the accidentally-tracked artifacts in the final commit.Verification
cargo metadata --manifest-path Cargo.toml --format-version 1resolves cleanly (exit 0).cargo check --manifest-path apps/desktop/src-tauri/Cargo.toml— blocked locally oncidre v0.14.2build script:xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance. This is a sandbox env issue (would needsudo xcode-select -swhich requires a password). Please verify locally.pnpm turbo typecheck --force— 6/6 successful.dprint fmt— 47 files formatted.cargo fmt --all— clean.rg -i 'posthog|trackEvent|tauri.plugin.analytics|hypr-analytics|AnalyticsPayload|AnalyticsPluginExt'excluding lockfiles/node_modules/target — zero hits.