Add string-based accessors for Request method - #108
Open
harmony7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method::get_method()/set_method()/with_method()only support the 9 standard HTTP verbs via theMethodenum, which cannot represent nonstandard-but-common verbs likePURGE.This PR adds
get_method_str(),Request::create(), and string overloads ofset_method()/with_method()that accept any valid HTTP method token, backed by the fastly crate's existingimpl ToMethodsupport for strings. Invalid tokens arereported via a new
FastlyErrorCode::InvalidMethodrather than panicking.Fixes #88
NOTE:
get_method()will panic if the method is not one of the nine. The right way to fix this is probably to change that function's signature to returnexpected<>, but that would be breaking.