-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
👷 Add ty to precommit
#2227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svlandeg
wants to merge
16
commits into
fastapi:master
Choose a base branch
from
svlandeg:feat/ty
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
👷 Add ty to precommit
#2227
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
261669c
add ty to precommit
svlandeg 3d0456e
fix syntax
svlandeg 0922a66
assert that configuration is not None
svlandeg 61d8a05
convert Item/User to ItemPublic/UserPublic
svlandeg 8c1470c
ty ignore unnecessary ignore statements
svlandeg 2b1a1e1
add one type ignore
svlandeg 30c4abd
two more fixes
svlandeg 20a410f
try with download version 4
svlandeg a0a79db
fix
svlandeg 59ef24d
ensure that a ty warning creates an error
svlandeg cbf8b85
Merge branch 'master' into feat/ty
svlandeg 33d1cc5
🎨 Auto format and update with pre-commit
pre-commit-ci-lite[bot] 946e9a0
Merge branch 'feat/ty' of https://github.com/svlandeg/full-stack-fast…
svlandeg 1ea0613
update to ty >= 0.0.25
svlandeg aee0392
try reverting the download version change
svlandeg 403f000
cleanup
svlandeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,5 +4,6 @@ set -e | |
| set -x | ||
|
|
||
| mypy app | ||
| ty check app | ||
| ruff check app | ||
| ruff format app --check | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little confused about this one, as
drop_constraintrequires astrconstraint name. Not sure why it wasNonebefore and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔