feat: Add length validation for superuser password#2192
Open
siyavash wants to merge 1 commit intofastapi:masterfrom
Open
feat: Add length validation for superuser password#2192siyavash wants to merge 1 commit intofastapi:masterfrom
siyavash wants to merge 1 commit intofastapi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the copier template by adding a validation step for the
first_superuser_password. It ensures that users cannot generate a project with a password shorter than 8 characters, which is a requirement for the backend.The Issue
Currently, when creating a project with this template, copier allows setting a short password (e.g., "salam"). However, the backend's UserCreate Pydantic model strictly validates that passwords must be at least 8 characters long.
This caused the
prestartservice to crash immediately after deployment with aValidationError, requiring manual intervention to fix the.envfile and restart services.Logs
The Fix
I updated copier.yml to:
{% if first_superuser_password|length < 8 %}to reject passwords shorter than 8 characters during generation.This ensures all new projects start with a valid configuration.