feat: support parser rounding modes - #24
Open
tisonkun wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoundModewith five non-redundant modes:Ceil,Floor,HalfCeil,HalfFloor, andHalfEven.ParseOptionswith a publicround_modefield andHalfCeilas its default.ByteSize::parse_with(input, options);FromStrdelegates to it withParseOptions::default(), preserving the existing ties-to-larger behavior for standard and Serde string parsing.u128arithmetic.cargo x test,cargo x lint, andcargo x bench.Design Notes
The rounding semantics are adapted from Jiff’s
RoundMode, but the API does not copy all nine variants.ByteSizeonly accepts non-negative values, makingExpandequivalent toCeil,Truncequivalent toFloor,HalfExpandequivalent toHalfCeil, andHalfTruncequivalent toHalfFloor. The public enum keeps one direction-based name for each distinct behavior relevant to this domain.The parsing API follows the cronexpr
ParseOptionspattern: configurable behavior lives in a defaultable, non-exhaustive options type, while the ordinary parsing path delegates to the configurable entry point with default options. This gives future parser settings a compatible place to compose without adding more specialized parsing methods.Fraction parsing always records whether any digit after the first discarded digit is nonzero. This removes both const-generic specialization and a per-digit mode branch; A/B benchmarks showed no material regression.