Repository navigation
fix(ios): wait for the APNs token in getToken - #38
Merged
Merged
Conversation
Signed-off-by: td <j.nirve@famedly.com>
krille-chan
reviewed
Nov 15, 2026
Signed-off-by: td <j.nirve@famedly.com>
td-famedly
marked this pull request as ready for review
November 15, 2026 19:54
krille-chan
approved these changes
Nov 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS
getToken()calledMessaging.token()before APNs had delivered the device token, which fails with FCM error 505 "No APNS token before fetching FCM Token". That is ~9.8k events in 90 days in the Famedly app (Sentry FAMEDLY-APP-A7T, FAMEDLY-APP-AEQ), mostly right after app start.getToken()now waits instead: whileapnsTokenis nil it registers for remote notifications and answers once APNs delivers the token, or with the registration error. The token is also handed toMessagingexplicitly, so this works with Firebase swizzling disabled.Follows the review on #33: awaiting
getToken()should wait for APNs and return the FCM token, not null. Bumps to 4.0.1.Refs FM-968
Draft until it has been built and cold-started once on iOS; CI only runs the Dart checks.