Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quality()andbest_match()split Accept lists at every comma, including commas inside quoted parameter values. For example, this valid media range raisesMimeTypeParseException:Split list members while tracking quoted strings and backslash escapes, as specified in RFC 9110 section 5.6.4. Preserve the original strings for parameter parsing. The common unquoted case continues to use
str.split().Added shared JSON cases for quality selection and tests covering quoted commas, escaped quotes, escaped backslashes, semicolons within quoted values, and blank list members.
Validation on Windows:
python mimeparse_test.pypasses.py312andpy314each pass all 6 test methods, including the shared JSON cases, on CPython 3.12.14 and 3.14.5.flake8andgit diff --checkpass.