fix: fall back to next scope when no restore keys#229
Open
dulacp wants to merge 1 commit intofalcondev-oss:devfrom
Open
fix: fall back to next scope when no restore keys#229dulacp wants to merge 1 commit intofalcondev-oss:devfrom
dulacp wants to merge 1 commit intofalcondev-oss:devfrom
Conversation
Contributor
|
This is probably the reason my storage requirements are blowing up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
A PR workflow that restores a cache gets a miss, even when an entry with the exact same key exists on the base branch scope.
Expected: the lookup should fall back from the PR scope (
refs/pull/N/merge) to the base-branch scope (refs/heads/main) and return that entry.Impact
Every PR misses the base-branch cache and creates its own copy on first run. In one repo we observed 26 duplicate copies of the same key across PR scopes because fallback never kicked in.
Fix
Change
returntocontinueso the loop proceeds to the next scope.Test
No existing test covers multi-scope lookups without restore keys. Happy to add one if helpful — the current
tests/e2e.test.tsuses a single scope so the bug doesn't surface there.