Repository navigation
Conversation
The cmd substitution %INSTALL_DIR:''=% strips doubled apostrophes instead of doubling single ones, so an install dir containing an apostrophe (e.g. C:\Users\O'Brien\...) broke the PowerShell quoting and silently skipped the PATH update. Use the correct '%'=''% idiom, fix the comments describing it, and pin the idiom plus the HKLM-key / unwritable-hive contracts with content-level tests. Review findings I-1 and I-2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183. Design:
docs/superpowers/specs/2026-11-17-windows-installer-polish-design.md(committed in this PR). Plan:docs/superpowers/plans/2026-11-18-windows-installer-polish.md.What's in the box
Windows MSI scope only (macOS DMG branding explicitly deferred per issue discussion):
pyproject.toml— new[tool.briefcase.app.profiles.windows]section: desktop shortcut (checked), scope wizard kept (per-user/per-machine), finish page (Launch ProFiles checkbox + Documentation / What's new links + completion texts), branded installer art, PATH install option, bundled scripts.install_option(array of tables, requiredname) — verified against the Briefcase 0.4.7 wheel; the plural key is silently swallowed byDraftAppConfig(same trap asdocument_type). The spec file in this PR reflects the corrected snippet, andtests/packaging/test_windows_installer_assets.pyguards it.packaging/windows/—post_install.bat(adds install dir to PATH per the checkbox; PowerShellDoNotExpandEnvironmentNamesread /ExpandStringwrite;WM_SETTINGCHANGEbroadcast; never fails the install) andpre_uninstall.bat(exact-match removal from both hives, configs/logs untouched), plus provenance README + BMP generator.img/installer_*.bmp— 493×312 / 493×58 committed BMPs derived fromimg/ProFiles_banner.png("brand gradient" direction approved in the brainstorming session)..gitattributes—*.bat text eol=crlf,*.bmp binary.build-windows.ymlalso rebuilds onpackaging/windows/**changes (so script-only pushes still produce a testable MSI).msiexec /qnopt-out documented; CHANGELOG[Unreleased]Added entries.Verification status
tests/packaging/test_windows_installer_assets.py.build-windows.ymlartifact (ProFiles-windows-msi) on this PR is the MSI to field-test.Windows test checklist (work machine)
profiles --headlessresolves.msiexec /x /qn): PATH entry gone from the right hive(s); shortcuts gone;.profilesconfigs and logs intact.msiexec /i ProFiles-<version>.msi /qn— silent install works, PATH added;OPTION_ADD_TO_PATH=0opt-out respected.C:\Program Files\ProFiles) if available.