Conversation
The en last_name list omits 40 of England's 60 most common surnames, among them Taylor, Williams, Wilson and Davies, while retaining rare legacy entries such as Altenwerth. This adds 62 surnames that are common across English speaking countries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
name.last_namein theenlocale omits 40 of England's 60 most common surnames, among themTaylor(rank 3),Williams(5),Wilson(6) andDavies(8). It does carry a tail of rare legacy entries:Altenwerth, for example, has roughly 66 bearers worldwide, all of them in Germany.Since
enis the fallback foren-GBand every other English locale excepten-US,Faker::Name.last_nameseldom returns a surname that reads as ordinary.Changes
62 surnames added to
lib/locales/en/name.yml, 472 to 534 entries. Nothing removed or renamed. This closes the England top-60 gap and fills in common surnames that were missing on the US side too, such asNelson,Stewart,Peterson,ReedandBrooks.Entries follow the file's existing order, which is case insensitive and ignores apostrophes, and
rake reformat_yamlleaves the result unchanged.Sourcing
No list was copied from a single source. Candidates were drawn from general knowledge of English surnames and checked individually against published surname frequency data, with the ranking cross-checked against England's surname frequency table.
Console output
Notes
Seeded output changes, since the length of the list changes.