Skip to content

fix Faker::Json width when keys collide #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpep wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix Faker::Json width when keys collide #3326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
976cb48
Keep Faker::Json width when generated keys collide
dpep Oct 4, 2026
5391683
Apply suggestion from @dpep
dpep Oct 4, 2026
3e48b73
Apply suggestion from @dpep
dpep Oct 4, 2026
ec4814c
Apply suggestion from @dpep
dpep Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/faker/default/json.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ def build_shallow_hash(width, options)
value = options[:value]

hash = {}
width.times do
# retry on duplicate
(width * 10).times do
break if hash.size == width

hash[eval(key)] = eval(value)
end
hash
Expand Down
9 changes: 9 additions & 0 deletions test/faker/default/test_faker_json.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
# frozen_string_literal: true

require 'minitest/mock'
require_relative '../../test_helper'

class TestFakerJson < Test::Unit::TestCase
require 'json'

def test_shallow_json_keeps_width_when_keys_collide
Faker::Config.stub :random, Random.new(0) do
json = Faker::Json.shallow_json(width: 2, options: { key: 'Boolean.boolean', value: 'Boolean.boolean' })

assert_equal 2, JSON.parse(json).size
end
end

def test_simple_json_lenght
expected_result_length = JSON.parse(simple_json).flatten.length

Expand Down