Skip to content

perf: Optimize Number generators with arithmetic instead of string building #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorshea wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −7
Open

perf: Optimize Number generators with arithmetic instead of string building #3293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/faker/default/number.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def number(digits: 10)
return rand(0..9).round if digits == 1

# Ensure the first digit is not zero
([non_zero_digit] + generate(digits - 1)).join.to_i
rand((10**(digits - 1))..(10**digits - 1))
end

##
Expand All @@ -32,7 +32,9 @@ def number(digits: 10)
#
# @faker.version 1.0.0
def leading_zero_number(digits: 10)
"0#{(2..digits).collect { digit }.join}"
return '0' if digits < 2

"0#{rand(10**(digits - 1)).to_s.rjust(digits - 1, '0')}"
end

##
Expand Down Expand Up @@ -71,7 +73,7 @@ def decimal(l_digits: 5, r_digits: 2)

# Ensure the last digit is not zero
# so it does not get truncated on converting to float
r_d = generate(r_digits - 1).join + non_zero_digit.to_s
r_d = ((rand(10**(r_digits - 1)) * 10) + non_zero_digit).to_s.rjust(r_digits, '0')

"#{l_d}.#{r_d}".to_f
end
Expand Down Expand Up @@ -113,8 +115,8 @@ def digit
#
# @faker.version 1.0.0
def hexadecimal(digits: 6)
hex = ''
digits.times { hex += rand(16).to_s(16) }
hex = ::String.new('', capacity: digits)
digits.times { hex << rand(16).to_s(16) }
hex
end

Expand All @@ -128,8 +130,8 @@ def hexadecimal(digits: 6)
#
# @faker.version next
def binary(digits: 4)
bin = ''
digits.times { bin += rand(2).to_s(2) }
bin = ::String.new('', capacity: digits)
digits.times { bin << rand(2).to_s(2) }
bin
end

Expand Down