Skip to content

perf: Avoid unnecessary word-list copies in Lorem.words #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorshea wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

perf: Avoid unnecessary word-list copies in Lorem.words #3292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/faker/default/lorem.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,16 @@ def word(exclude_words: nil)
# @faker.version 2.1.3
def words(number: 3, supplemental: false, exclude_words: nil)
resolved_num = resolve(number)
word_list = (
translate('faker.lorem.words') +
(supplemental ? translate('faker.lorem.supplemental') : [])
)
word_list = translate('faker.lorem.words')
word_list += translate('faker.lorem.supplemental') if supplemental
if exclude_words
exclude_words = exclude_words.split(', ') if exclude_words.instance_of?(::String)
word_list -= exclude_words
end
word_list *= ((resolved_num / word_list.length) + 1)
# Duplicate the word list only when more words are requested than the
# list contains. Never mutate word_list itself: it may be the array
# cached by the I18n backend.
word_list *= ((resolved_num / word_list.length) + 1) if resolved_num > word_list.length
sample(word_list, resolved_num)
end

Expand Down