Verify DID of incoming package during an update#441
Draft
johnbillion wants to merge 3 commits intofairpm:release_1.4.0from
Draft
Verify DID of incoming package during an update#441johnbillion wants to merge 3 commits intofairpm:release_1.4.0from
johnbillion wants to merge 3 commits intofairpm:release_1.4.0from
Conversation
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Contributor
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440 by finding and validating the DID in the incoming package during an update.
The
upgrader_source_selectionhook at priority9means it fires just beforeFAIR\Packages\move_package_during_install()so all the logic there gets bypassed if the DID is not valid.Similarly to the signature verification, this halts the update process if the DID verification fails.
Steps to test
...